Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] connector_dns #24

Closed
wants to merge 4 commits into from
Closed

[ADD] connector_dns #24

wants to merge 4 commits into from

Conversation

noahzaozao
Copy link

No description provided.

@noahzaozao
Copy link
Author

noahzaozao commented Aug 19, 2016

@elicoidal @duanyp1991 since the PR of oca_depand has been merged , I merged it to my branch and push to this PR , but it's still error with not find 'connector'. I wondering whether we should also PR the oca_dependencies.txt to the branch 9.0 ?

@elicoidal
Copy link
Contributor

@noahzaozao You might need to rebase your PR so that the oca_dependency is included in it.
If it doesnot work, I will ask some help

@noahzaozao
Copy link
Author

@elicoidal I've rebase my PR with 8.0 branch , and seems it's still not work.

@elicoidal
Copy link
Contributor

@pedrobaeza @dreispt any help is welcome here

@dreispt
Copy link
Sponsor Member

dreispt commented Aug 21, 2016

Sorry, Runbot is not something I can help.
But you should definitely setup TravCI tests. Copying from business requirements repo would be a good start.

@elicoidal
Copy link
Contributor

@DreisP, thanks for this piece of advice. We will proceed

@elicoidal
Copy link
Contributor

@noahzaozao check the repo https://github.com/oca/business-requirement for the setup as it seems that this repo is not finished yet. Thanks

@coveralls
Copy link

coveralls commented Aug 23, 2016

Coverage Status

Coverage remained the same at 56.757% when pulling 21d1255 on noahzaozao:8.0-noah-imp-connector-dns into 1b0c4f6 on OCA:8.0.

@coveralls
Copy link

coveralls commented Aug 23, 2016

Coverage Status

Coverage remained the same at 56.757% when pulling 073bf9c on noahzaozao:8.0-noah-imp-connector-dns into 1b0c4f6 on OCA:8.0.

@noahzaozao
Copy link
Author

@elicoidal Since the travis and coverall are green , seems the runbot still can't find 'connector' from OCA

@elicoidal
Copy link
Contributor

Added the connector in the runbot setup

@coveralls
Copy link

coveralls commented Aug 23, 2016

Coverage Status

Coverage remained the same at 56.757% when pulling 47bd6a8 on noahzaozao:8.0-noah-imp-connector-dns into 1b0c4f6 on OCA:8.0.

@coveralls
Copy link

coveralls commented Aug 23, 2016

Coverage Status

Coverage remained the same at 56.463% when pulling 927c9c2 on noahzaozao:8.0-noah-imp-connector-dns into 1b0c4f6 on OCA:8.0.

@coveralls
Copy link

coveralls commented Aug 23, 2016

Coverage Status

Coverage remained the same at 56.463% when pulling 927c9c2 on noahzaozao:8.0-noah-imp-connector-dns into 1b0c4f6 on OCA:8.0.

@noahzaozao
Copy link
Author

noahzaozao commented Aug 23, 2016

@elicoidal could you review this PR , current it's passed all checks , thanks.

@dreispt
Copy link
Sponsor Member

dreispt commented Aug 23, 2016

Is this is not specific to the CN licalization, shoudn't it go in a different repo, as discussed in the ML?

@elicoidal
Copy link
Contributor

@dreispt True but a little bit more complicated than that.
dnspod.cn provider could fit in the localization (it is all Chinese) but the connector should be in a more specific repo. That's why we initially pushed here (and then proposed an alternative)
Anyway I am waiting for the decision on repo to eventually move them both in the final destination. In the meantime we will finetune the PR here.

:alt: License

=============
Connector Dns

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DNS

@elicoidal
Copy link
Contributor

@noahzaozao mostly the README to update to the latest template.
Later on I might improve it to include a simple user manual

@coveralls
Copy link

coveralls commented Aug 24, 2016

Coverage Status

Coverage remained the same at 56.463% when pulling 354af50 on noahzaozao:8.0-noah-imp-connector-dns into 1b0c4f6 on OCA:8.0.

* Noah Wang <noah.wang@elico-corp.com>
* Liu Lixia <contact@elico-corp.com>
* Augustin Cisterne-Kaas
* Contact <contact@elico-corp.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this email is for Augustin

@coveralls
Copy link

coveralls commented Aug 24, 2016

Coverage Status

Coverage remained the same at 56.463% when pulling 400cb0b on noahzaozao:8.0-noah-imp-connector-dns into 1b0c4f6 on OCA:8.0.

@coveralls
Copy link

coveralls commented Aug 24, 2016

Coverage Status

Coverage remained the same at 56.463% when pulling 400cb0b on noahzaozao:8.0-noah-imp-connector-dns into 1b0c4f6 on OCA:8.0.

@elicoidal
Copy link
Contributor

👍
@guewen @lasley @pedrobaeza can you help on the review and merge?

@elicoidal
Copy link
Contributor

elicoidal commented Aug 26, 2016

@guewen @lasley @pedrobaeza: Ignore my cry for help!
First we need to move forward with the infra-* repo...

@elicoidal
Copy link
Contributor

@noahzaozao can you close this PR and transfer it to https://github.com/OCA/infrastructure-dns ?
I will add that repo as dependency of this one (and remove the one from connector which is not needed anymore)

@noahzaozao noahzaozao closed this Aug 29, 2016
@elicoidal
Copy link
Contributor

superseded by OCA/infrastructure#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants